979 Commits

Author SHA1 Message Date
adroitwhiz
bc5969f89d
Merge pull request #568 from adroitwhiz/extract-drawable-screen-space
Add extractDrawableScreenSpace method
2020-07-21 14:57:23 -04:00
adroitwhiz
138cabe3c1
Merge pull request #660 from adroitwhiz/revert-489
Revert "Merge pull request #489 from adroitwhiz/touching-white-fixes"
2020-07-16 15:31:54 -04:00
adroitwhiz
116d147faf Revert "Merge pull request #489 from adroitwhiz/touching-white-fixes"
This reverts commit a1ca2eb9240af25808f62286e1272ae759378640, reversing
changes made to fcdcffeec899643fee3a4c5a3bccd668e9a2f0af.
2020-07-16 15:07:16 -04:00
adroitwhiz
6977471ebf
Merge pull request #659 from adroitwhiz/fix-jsdoc-complaints
Fix @type annotations so JSDoc doesn't complain
2020-07-14 16:45:43 -04:00
adroitwhiz
56f673972a Fix @type annotations so JSDoc doesn't complain 2020-07-14 16:36:12 -04:00
adroitwhiz
a1ca2eb924
Merge pull request #489 from adroitwhiz/touching-white-fixes
Fix "touching color" for background color
2020-07-14 16:22:18 -04:00
adroitwhiz
7a6b3c55aa
Apply suggestions from code review
Co-authored-by: Chris Willis-Ford <7019101+cwillisf@users.noreply.github.com>
2020-07-14 16:17:12 -04:00
adroitwhiz
1437574261 Comment extractDrawableScreenSpace better 2020-07-09 16:54:47 -04:00
adroitwhiz
a4e5f8e3b9 Re-disable ghost effect 2020-07-09 16:27:23 -04:00
adroitwhiz
fcdcffeec8
Merge pull request #581 from adroitwhiz/remove-set-rotation-center
Remove setRotationCenter API
2020-07-09 15:43:11 -04:00
adroitwhiz
c0b339f9dc Make text bubble test robust against future errors
Now, the test will check that text bubbles are not being touched both
immediately after appearing and 0.1 seconds after appearing.
2020-07-08 16:09:43 -04:00
adroitwhiz
ac935423af Don't include text bubbles in touching queries 2020-07-06 16:13:48 -04:00
adroitwhiz
75a4792f93 Cache and don't re-create transformed hull points 2020-06-25 16:33:22 -04:00
adroitwhiz
d9c854f1fc Remove setRotationCenter API 2020-06-23 02:29:14 -04:00
adroitwhiz
0d86ec92ed Don't blur vector skins 2020-06-22 17:33:45 -04:00
adroitwhiz
26988e398f Clean up SVGSkin 2020-06-22 17:33:45 -04:00
DD Liu
1c0928f441
Merge pull request #648 from LLK/dependabot/npm_and_yarn/scratch-vm-0.2.0-prerelease.20200622143012
Bump scratch-vm from 0.2.0-prerelease.20200616200729 to 0.2.0-prerelease.20200622143012
2020-06-22 16:24:09 -04:00
dependabot-preview[bot]
a46a063c81
Bump scratch-vm
Bumps [scratch-vm](https://github.com/LLK/scratch-vm) from 0.2.0-prerelease.20200616200729 to 0.2.0-prerelease.20200622143012.
- [Release notes](https://github.com/LLK/scratch-vm/releases)
- [Commits](https://github.com/LLK/scratch-vm/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-22 14:35:15 +00:00
adroitwhiz
19398fa67a Fix typo: "that half-pixel stil" 2020-06-17 16:09:19 -04:00
adroitwhiz
a2bc5a4974 Fix "drawable's bounds" comments 2020-06-17 16:07:24 -04:00
adroitwhiz
8db14c5094 Clean up background color stuff 2020-06-17 16:01:17 -04:00
DD Liu
e0d7d60a68
Merge pull request #643 from LLK/dependabot/npm_and_yarn/scratch-vm-0.2.0-prerelease.20200616200729
Bump scratch-vm from 0.2.0-prerelease.20191227164934 to 0.2.0-prerelease.20200616200729
2020-06-17 14:54:04 -04:00
adroitwhiz
4fa042cead Remove unnecessary shader stuff 2020-06-17 14:19:44 -04:00
dependabot-preview[bot]
c4534e85ca
Bump scratch-vm
Bumps [scratch-vm](https://github.com/LLK/scratch-vm) from 0.2.0-prerelease.20191227164934 to 0.2.0-prerelease.20200616200729.
- [Release notes](https://github.com/LLK/scratch-vm/releases)
- [Commits](https://github.com/LLK/scratch-vm/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-17 03:47:19 +00:00
DD Liu
7bc79cfb09
Merge pull request #524 from Ryuurock/pick-reduce_unnecessary_traversal
Reduce unnecessary traversal
2020-06-15 16:09:46 -04:00
Ryuurock
ab21dd106e Reduce unnecessary traversal 2020-06-11 15:54:06 -04:00
DD Liu
d8ec3b92a0
Merge pull request #638 from fsih/updateSvgRend
Update svg renderer
2020-06-10 18:38:00 -04:00
DD Liu
9e59094d91 Update svg renderer 2020-06-10 18:37:24 -04:00
adroitwhiz
f09131ea64 Snap _candidatesTouching bounds to integer coords
When we construct bounds inside which we should loop over pixels, which
is done in _candidatesBounds, we expect their dimensions+position to be
integers when looping over them. If they aren't, weird things will occur
(e.g. "phantom" touching-color results depending on the precise subpixel
bounds position) that are not very fun to debug.
2020-06-10 17:24:05 -04:00
adroitwhiz
a7d636827c add touching color test for common clear colors 2020-06-10 16:36:18 -04:00
adroitwhiz
99ff2ba11e Fix touching color check for background color 2020-06-10 16:36:18 -04:00
DD Liu
77ccf97886
Update CONTRIBUTING.md 2020-06-09 17:02:31 -04:00
DD Liu
dcb282acca
Merge pull request #634 from LLK/dependabot/npm_and_yarn/scratch-svg-renderer-0.2.0-prerelease.20200604203226
Bump scratch-svg-renderer from 0.2.0-prerelease.20200507183648 to 0.2.0-prerelease.20200604203226
2020-06-09 16:02:43 -04:00
adroitwhiz
67e372c088
Merge pull request #600 from adroitwhiz/i-despise-floats
Rewrite the pen line shader to be more numerically stable
2020-06-09 15:21:03 -04:00
dependabot-preview[bot]
b71c8b73d7
Bump scratch-svg-renderer
Bumps [scratch-svg-renderer](https://github.com/LLK/scratch-svg-renderer) from 0.2.0-prerelease.20200507183648 to 0.2.0-prerelease.20200604203226.
- [Release notes](https://github.com/LLK/scratch-svg-renderer/releases)
- [Commits](https://github.com/LLK/scratch-svg-renderer/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-05 09:18:59 +00:00
adroitwhiz
de4073ce7d
Merge pull request #569 from adroitwhiz/extract-drawable-delete-framebuffer
Delete framebuffer in extractDrawable
2020-06-04 17:00:21 -04:00
adroitwhiz
04cc67139e Delete framebuffer in extractDrawable 2020-06-02 16:01:31 -04:00
adroitwhiz
204413ab19
Merge pull request #555 from adroitwhiz/update-silhouette-more
Handle matrix + silhouette updates better
2020-06-02 15:55:20 -04:00
adroitwhiz
7586e1c890 Add logging to updateCPURenderAttributes 2020-05-20 16:07:59 -04:00
adroitwhiz
e7b1504117 Move matrix + silhouette updates into method 2020-05-19 16:02:12 -04:00
adroitwhiz
b5e27462d9 Pass line length as a uniform
HATE. LET ME TELL YOU HOW MUCH I'VE COME TO HATE GLSL FLOATS SINCE I BEGAN TO LIVE. THERE ARE 387.44 MILLION MILES OF PRINTED CIRCUITS IN WAFER THIN LAYERS ACROSS THE MILLIONS OF MOBILE GPUS ACROSS THE WORLD. IF THE WORD HATE WAS ENGRAVED ON EACH NANOANGSTROM OF THOSE HUNDREDS OF MILLIONS OF MILES IT WOULD NOT EQUAL ONE ONE-BILLIONTH OF THE HATE I FEEL FOR GLSL FLOATS AT THIS MICRO-INSTANT. HATE. HATE.
2020-05-14 09:39:43 -04:00
adroitwhiz
d73aeb1ac1
Merge pull request #598 from adroitwhiz/cpu-gpu-integration-tests
Run integration tests on both the CPU and GPU (again)
2020-05-12 16:24:10 -04:00
Christopher Willis-Ford
298200f2ee Make touching-color test more robust against GPU imprecision
Previously, the `color-touching-tests.sb2` test "touches a color that
doesn't actually exist right now" would use a sprite with ghost 50,
blended against another sprite, to create the color that "doesn't
actually exist" when the query sprite is skipped. Unfortunately the
blend result was near a bit-boundary and, depending on the specific
hardware used, that test could fail on the GPU. When the renderer uses
the CPU path this test works fine, though, so the existing problem went
unnoticed.

To fix the problem I changed the project to use ghost 30 instead, which
results in a color that is less near a bit boundary and is therefore
less likely to fail on specific hardware.

As an example of what was happening: the `touching color` block was
checking for `RGB(127,101,216)` with a mask of `RGB(0xF8,0xF8,0xF0)`. On
the CPU it would find `RGB(120,99,215)`, which is in range, but on some
GPUs the closest color it could find was `RGB(119,98,215)` which
mismatches on all four of the least significant bits -- one of which is
enabled in the mask.
2020-05-12 15:52:51 -04:00
adroitwhiz
b9411bf51e Skip "doesn't touch say bubble" test
There are some compatibility concerns to be worked out before the
corresponding bug can be fixed.
2020-05-12 15:52:51 -04:00
adroitwhiz
3513cd77ae Adapt f9428ee to Playwright 2020-05-12 15:52:51 -04:00
adroitwhiz
d8c9f339f7
Merge pull request #576 from adroitwhiz/fix-ghost-touching-color
Don't apply ghost effect to "color is touching color" drawable
2020-05-11 16:29:17 -04:00
adroitwhiz
aaffc77b23 Clarify isTouchingColor ghost comment 2020-05-11 16:07:05 -04:00
adroitwhiz
d867e62c74 Don't apply ghost to "touching color" drawables 2020-05-11 16:07:05 -04:00
adroitwhiz
a7bec3a958
Merge pull request #604 from adroitwhiz/playwright
Playwright: the re-wright
2020-05-11 15:50:57 -04:00
adroitwhiz
0ce50b6cd6 log error.message 2020-05-11 15:38:11 -04:00