chore(package): update tap to version 14.7.1

Closes #289

package.json

@@ -38,7 +38,7 @@
     "jsdoc": "^3.5.5",
     "json": "^9.0.4",
     "scratch-vm": "0.2.0-prerelease.20190207224121",
-    "tap": "^11.0.0",
+    "tap": "^14.7.1",
     "travis-after-all": "^1.4.4",
     "uglifyjs-webpack-plugin": "^1.2.5",
     "webpack": "^4.8.0",
@@ -54,6 +54,6 @@
     "raw-loader": "^0.5.1",
     "scratch-storage": "^1.0.0",
     "scratch-svg-renderer": "0.2.0-prerelease.20190822202608",
-    "twgl.js": "4.12.0"
+    "twgl.js": "4.4.0"
   }
 }

src/BitmapSkin.js

@@ -56,7 +56,7 @@ class BitmapSkin extends Skin {
      */
     // eslint-disable-next-line no-unused-vars
     getTexture (scale) {
-        return this._texture || super.getTexture();
+        return this._texture;
     }
 
     /**
@@ -78,10 +78,6 @@ class BitmapSkin extends Skin {
      * @fires Skin.event:WasAltered
      */
     setBitmap (bitmapData, costumeResolution, rotationCenter) {
-        if (!bitmapData.width || !bitmapData.height) {
-            super.setEmptyImageData();
-            return;
-        }
         const gl = this._renderer.gl;
 
         // Preferably bitmapData is ImageData. ImageData speeds up updating

src/SVGSkin.js

@@ -66,10 +66,6 @@ class SVGSkin extends Skin {
      */
     // eslint-disable-next-line no-unused-vars
     getTexture (scale) {
-        if (!this._svgRenderer.canvas.width || !this._svgRenderer.canvas.height) {
-            return super.getTexture();
-        }
-
         // The texture only ever gets uniform scale. Take the larger of the two axes.
         const scaleMax = scale ? Math.max(Math.abs(scale[0]), Math.abs(scale[1])) : 100;
         const requestedScale = Math.min(scaleMax / 100, this._maxTextureScale);
@@ -112,12 +108,6 @@ class SVGSkin extends Skin {
             // updating Silhouette and is better handled by more browsers in
             // regards to memory.
             const canvas = this._svgRenderer.canvas;
-
-            if (!canvas.width || !canvas.height) {
-                super.setEmptyImageData();
-                return;
-            }
-
             const context = canvas.getContext('2d');
             const textureData = context.getImageData(0, 0, canvas.width, canvas.height);
 

src/Skin.js

@@ -140,7 +140,7 @@ class Skin extends EventEmitter {
      */
     // eslint-disable-next-line no-unused-vars
     getTexture (scale) {
-        return this._emptyImageTexture;
+        return null;
     }
 
     /**
@@ -171,38 +171,6 @@ class Skin extends EventEmitter {
      */
     updateSilhouette () {}
 
-    /**
-     * Set the contents of this skin to an empty skin.
-     * @fires Skin.event:WasAltered
-     */
-    setEmptyImageData () {
-        // Free up the current reference to the _texture
-        this._texture = null;
-
-        if (!this._emptyImageData) {
-            // Create a transparent pixel
-            this._emptyImageData = new ImageData(1, 1);
-
-            // Create a new texture and update the silhouette
-            const gl = this._renderer.gl;
-
-            const textureOptions = {
-                auto: true,
-                wrap: gl.CLAMP_TO_EDGE,
-                src: this._emptyImageData
-            };
-
-            // Note: we're using _emptyImageTexture here instead of _texture
-            // so that we can cache this empty texture for later use as needed.
-            // this._texture can get modified by other skins (e.g. BitmapSkin
-            // and SVGSkin, so we can't use that same field for caching)
-            this._emptyImageTexture = twgl.createTexture(gl, textureOptions);
-        }
-
-        this._silhouette.update(this._emptyImageData);
-        this.emit(Skin.Events.WasAltered);
-    }
-
     /**
      * Does this point touch an opaque or translucent point on this skin?
      * Nearest Neighbor version