chore(package): update eslint to version 6.4.0

Closes #307

package.json

@@ -32,13 +32,13 @@
     "chromeless": "^1.5.1",
     "copy-webpack-plugin": "^4.5.1",
     "docdash": "^0.4.0",
-    "eslint": "^4.6.1",
+    "eslint": "^6.4.0",
     "eslint-config-scratch": "^5.0.0",
     "gh-pages": "^1.0.0",
     "jsdoc": "^3.5.5",
     "json": "^9.0.4",
     "scratch-vm": "0.2.0-prerelease.20190207224121",
-    "tap": "^14.8.0",
+    "tap": "^11.0.0",
     "travis-after-all": "^1.4.4",
     "uglifyjs-webpack-plugin": "^1.2.5",
     "webpack": "^4.8.0",

src/Drawable.js

@@ -183,99 +183,56 @@ class Drawable {
         return this._visible;
     }
 
-    /**
-     * Update the position if it is different. Marks the transform as dirty.
-     * @param {Array.<number>} position A new position.
-     */
-    updatePosition (position) {
-        if (this._position[0] !== position[0] ||
-            this._position[1] !== position[1]) {
-            this._position[0] = Math.round(position[0]);
-            this._position[1] = Math.round(position[1]);
-            this.setTransformDirty();
-        }
-    }
-
-    /**
-     * Update the direction if it is different. Marks the transform as dirty.
-     * @param {number} direction A new direction.
-     */
-    updateDirection (direction) {
-        if (this._direction !== direction) {
-            this._direction = direction;
-            this._rotationTransformDirty = true;
-            this.setTransformDirty();
-        }
-    }
-
-    /**
-     * Update the scale if it is different. Marks the transform as dirty.
-     * @param {Array.<number>} scale A new scale.
-     */
-    updateScale (scale) {
-        if (this._scale[0] !== scale[0] ||
-            this._scale[1] !== scale[1]) {
-            this._scale[0] = scale[0];
-            this._scale[1] = scale[1];
-            this._rotationCenterDirty = true;
-            this._skinScaleDirty = true;
-            this.setTransformDirty();
-        }
-    }
-
-    /**
-     * Update visibility if it is different. Marks the convex hull as dirty.
-     * @param {boolean} visible A new visibility state.
-     */
-    updateVisible (visible) {
-        if (this._visible !== visible) {
-            this._visible = visible;
-            this.setConvexHullDirty();
-        }
-    }
-
-    /**
-     * Update an effect. Marks the convex hull as dirty if the effect changes shape.
-     * @param {string} effectName The name of the effect.
-     * @param {number} rawValue A new effect value.
-     */
-    updateEffect (effectName, rawValue) {
-        const effectInfo = ShaderManager.EFFECT_INFO[effectName];
-        if (rawValue) {
-            this._effectBits |= effectInfo.mask;
-        } else {
-            this._effectBits &= ~effectInfo.mask;
-        }
-        const converter = effectInfo.converter;
-        this._uniforms[effectInfo.uniformName] = converter(rawValue);
-        if (effectInfo.shapeChanges) {
-            this.setConvexHullDirty();
-        }
-    }
-
     /**
      * Update the position, direction, scale, or effect properties of this Drawable.
-     * @deprecated Use specific update* methods instead.
      * @param {object.<string,*>} properties The new property values to set.
      */
     updateProperties (properties) {
-        if ('position' in properties) {
-            this.updatePosition(properties.position);
+        let dirty = false;
+        if ('position' in properties && (
+            this._position[0] !== properties.position[0] ||
+            this._position[1] !== properties.position[1])) {
+            this._position[0] = Math.round(properties.position[0]);
+            this._position[1] = Math.round(properties.position[1]);
+            dirty = true;
         }
-        if ('direction' in properties) {
-            this.updateDirection(properties.direction);
+        if ('direction' in properties && this._direction !== properties.direction) {
+            this._direction = properties.direction;
+            this._rotationTransformDirty = true;
+            dirty = true;
         }
-        if ('scale' in properties) {
-            this.updateScale(properties.scale);
+        if ('scale' in properties && (
+            this._scale[0] !== properties.scale[0] ||
+            this._scale[1] !== properties.scale[1])) {
+            this._scale[0] = properties.scale[0];
+            this._scale[1] = properties.scale[1];
+            this._rotationCenterDirty = true;
+            this._skinScaleDirty = true;
+            dirty = true;
         }
         if ('visible' in properties) {
-            this.updateVisible(properties.visible);
+            this._visible = properties.visible;
+            this.setConvexHullDirty();
+        }
+        if (dirty) {
+            this.setTransformDirty();
         }
         const numEffects = ShaderManager.EFFECTS.length;
         for (let index = 0; index < numEffects; ++index) {
             const effectName = ShaderManager.EFFECTS[index];
             if (effectName in properties) {
-                this.updateEffect(effectName, properties[effectName]);
+                const rawValue = properties[effectName];
+                const effectInfo = ShaderManager.EFFECT_INFO[effectName];
+                if (rawValue) {
+                    this._effectBits |= effectInfo.mask;
+                } else {
+                    this._effectBits &= ~effectInfo.mask;
+                }
+                const converter = effectInfo.converter;
+                this._uniforms[effectInfo.uniformName] = converter(rawValue);
+                if (effectInfo.shapeChanges) {
+                    this.setConvexHullDirty();
+                }
             }
         }
     }
@@ -573,6 +530,7 @@ class Drawable {
      * @return {!Rectangle} Bounds for the Drawable.
      */
     getFastBounds (result) {
+        this.updateMatrix();
         if (!this.needsConvexHullPoints()) {
             return this.getBounds(result);
         }

src/PenSkin.js

@@ -332,7 +332,8 @@ class PenSkin extends Skin {
 
         const uniforms = {
             u_skin: this._texture,
-            u_projectionMatrix: projection
+            u_projectionMatrix: projection,
+            u_fudge: 0
         };
 
         twgl.setUniforms(currentShader, uniforms);
@@ -473,7 +474,8 @@ class PenSkin extends Skin {
                     0
                 ), __modelScalingMatrix),
                 __modelMatrix
-            )
+            ),
+            u_fudge: 0
         };
 
         twgl.setTextureParameters(gl, texture, {minMag: gl.NEAREST});

src/RenderWebGL.js

@@ -1314,122 +1314,9 @@ class RenderWebGL extends EventEmitter {
         }, null);
     }
 
-    /**
-     * Update a drawable's skin.
-     * @param {number} drawableID The drawable's id.
-     * @param {number} skinId The skin to update to.
-     */
-    updateDrawableSkinId (drawableID, skinId) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.skin = this._allSkins[skinId];
-    }
-
-    /**
-     * Update a drawable's skin rotation center.
-     * @param {number} drawableID The drawable's id.
-     * @param {Array.<number>} rotationCenter The rotation center for the skin.
-     */
-    updateDrawableRotationCenter (drawableID, rotationCenter) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.skin.setRotationCenter(rotationCenter[0], rotationCenter[1]);
-    }
-
-    /**
-     * Update a drawable's skin and rotation center together.
-     * @param {number} drawableID The drawable's id.
-     * @param {number} skinId The skin to update to.
-     * @param {Array.<number>} rotationCenter The rotation center for the skin.
-     */
-    updateDrawableSkinIdRotationCenter (drawableID, skinId, rotationCenter) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.skin = this._allSkins[skinId];
-        drawable.skin.setRotationCenter(rotationCenter[0], rotationCenter[1]);
-    }
-
-    /**
-     * Update a drawable's position.
-     * @param {number} drawableID The drawable's id.
-     * @param {Array.<number>} position The new position.
-     */
-    updateDrawablePosition (drawableID, position) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.updatePosition(position);
-    }
-
-    /**
-     * Update a drawable's direction.
-     * @param {number} drawableID The drawable's id.
-     * @param {number} direction A new direction.
-     */
-    updateDrawableDirection (drawableID, direction) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.updateDirection(direction);
-    }
-
-    /**
-     * Update a drawable's scale.
-     * @param {number} drawableID The drawable's id.
-     * @param {Array.<number>} scale A new scale.
-     */
-    updateDrawableScale (drawableID, scale) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.updateScale(scale);
-    }
-
-    /**
-     * Update a drawable's direction and scale together.
-     * @param {number} drawableID The drawable's id.
-     * @param {number} direction A new direction.
-     * @param {Array.<number>} scale A new scale.
-     */
-    updateDrawableDirectionScale (drawableID, direction, scale) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.updateDirection(direction);
-        drawable.updateScale(scale);
-    }
-
-    /**
-     * Update a drawable's visibility.
-     * @param {number} drawableID The drawable's id.
-     * @param {boolean} visible Will the drawable be visible?
-     */
-    updateDrawableVisible (drawableID, visible) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.updateVisible(visible);
-    }
-
-    /**
-     * Update a drawable's visual effect.
-     * @param {number} drawableID The drawable's id.
-     * @param {string} effectName The effect to change.
-     * @param {number} value A new effect value.
-     */
-    updateDrawableEffect (drawableID, effectName, value) {
-        const drawable = this._allDrawables[drawableID];
-        // TODO: https://github.com/LLK/scratch-vm/issues/2288
-        if (!drawable) return;
-        drawable.updateEffect(effectName, value);
-    }
 
     /**
      * Update the position, direction, scale, or effect properties of this Drawable.
-     * @deprecated Use specific updateDrawable* methods instead.
      * @param {int} drawableID The ID of the Drawable to update.
      * @param {object.<string,*>} properties The new property values to set.
      */
@@ -1437,16 +1324,17 @@ class RenderWebGL extends EventEmitter {
         const drawable = this._allDrawables[drawableID];
         if (!drawable) {
             /**
-             * @todo(https://github.com/LLK/scratch-vm/issues/2288) fix whatever's wrong in the VM which causes this, then add a warning or throw here.
+             * @todo fix whatever's wrong in the VM which causes this, then add a warning or throw here.
              * Right now this happens so much on some projects that a warning or exception here can hang the browser.
              */
             return;
         }
         if ('skinId' in properties) {
-            this.updateDrawableSkinId(drawableID, properties.skinId);
+            drawable.skin = this._allSkins[properties.skinId];
         }
         if ('rotationCenter' in properties) {
-            this.updateDrawableRotationCenter(drawableID, properties.rotationCenter);
+            const newRotationCenter = properties.rotationCenter;
+            drawable.skin.setRotationCenter(newRotationCenter[0], newRotationCenter[1]);
         }
         drawable.updateProperties(properties);
     }
@@ -1463,7 +1351,7 @@ class RenderWebGL extends EventEmitter {
 
         const drawable = this._allDrawables[drawableID];
         if (!drawable) {
-            // @todo(https://github.com/LLK/scratch-vm/issues/2288) fix whatever's wrong in the VM which causes this, then add a warning or throw here.
+            // TODO: fix whatever's wrong in the VM which causes this, then add a warning or throw here.
             // Right now this happens so much on some projects that a warning or exception here can hang the browser.
             return [x, y];
         }
@@ -1720,7 +1608,8 @@ class RenderWebGL extends EventEmitter {
                 gl.useProgram(currentShader.program);
                 twgl.setBuffersAndAttributes(gl, currentShader, this._bufferInfo);
                 Object.assign(uniforms, {
-                    u_projectionMatrix: projection
+                    u_projectionMatrix: projection,
+                    u_fudge: window.fudge || 0
                 });
             }
 

src/shaders/sprite.frag

@@ -1,5 +1,7 @@
 precision mediump float;
 
+uniform float u_fudge;
+
 #ifdef DRAW_MODE_silhouette
 uniform vec4 u_silhouetteColor;
 #else // DRAW_MODE_silhouette