chore(package): update tap to version 12.0.2

Closes #289

package.json

@@ -31,14 +31,14 @@
     "babel-preset-env": "^1.6.1",
     "chromeless": "^1.5.1",
     "copy-webpack-plugin": "^4.5.1",
-    "docdash": "^1.0.1",
+    "docdash": "^0.4.0",
     "eslint": "^4.6.1",
     "eslint-config-scratch": "^5.0.0",
     "gh-pages": "^1.0.0",
     "jsdoc": "^3.5.5",
     "json": "^9.0.4",
     "scratch-vm": "0.2.0-prerelease.20181024204838",
-    "tap": "^11.0.0",
+    "tap": "^12.0.2",
     "travis-after-all": "^1.4.4",
     "uglifyjs-webpack-plugin": "^1.2.5",
     "webpack": "^4.8.0",
@@ -53,7 +53,7 @@
     "minilog": "3.1.0",
     "raw-loader": "^0.5.1",
     "scratch-storage": "^1.0.0",
-    "scratch-svg-renderer": "0.2.0-prerelease.20181126212715",
+    "scratch-svg-renderer": "0.2.0-prerelease.20181024192149",
     "twgl.js": "4.4.0"
   }
 }

src/util/svg-text-bubble.js

@@ -145,16 +145,11 @@ class SVGTextBubble {
             </g>`;
     }
 
-    _getTextSize (textFragment) {
-        const svgString = this._wrapSvgFragment(textFragment);
+
+    _getTextSize () {
+        const svgString = this._wrapSvgFragment(this._textFragment);
         if (!this._textSizeCache[svgString]) {
             this._textSizeCache[svgString] = this.svgRenderer.measure(svgString);
-            if (this._textSizeCache[svgString].height === 0) {
-                // The speech bubble is empty, so use the height of a single line with content (or else it renders
-                // weirdly, see issue #302).
-                const dummyFragment = this._buildTextFragment('X');
-                this._textSizeCache[svgString] = this._getTextSize(dummyFragment);
-            }
         }
         return this._textSizeCache[svgString];
     }
@@ -188,7 +183,7 @@ class SVGTextBubble {
         let fragment = '';
 
         const radius = 16;
-        const {x, y, width, height} = this._getTextSize(this._textFragment);
+        const {x, y, width, height} = this._getTextSize();
         const padding = 10;
         const fullWidth = Math.max(MIN_WIDTH, width) + (2 * padding);
         const fullHeight = height + (2 * padding);