github/scratch-render
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
834 Commits 188 Branches 22 Tags
Commit Graph

834 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
adroitwhiz
e7b1504117 Move matrix + silhouette updates into method 2020-05-19 16:02:12 -04:00
adroitwhiz
d73aeb1ac1
Merge pull request #598 from adroitwhiz/cpu-gpu-integration-tests 
Run integration tests on both the CPU and GPU (again)
 2020-05-12 16:24:10 -04:00
Christopher Willis-Ford
298200f2ee Make touching-color test more robust against GPU imprecision 
Previously, the `color-touching-tests.sb2` test "touches a color that
doesn't actually exist right now" would use a sprite with ghost 50,
blended against another sprite, to create the color that "doesn't
actually exist" when the query sprite is skipped. Unfortunately the
blend result was near a bit-boundary and, depending on the specific
hardware used, that test could fail on the GPU. When the renderer uses
the CPU path this test works fine, though, so the existing problem went
unnoticed.

To fix the problem I changed the project to use ghost 30 instead, which
results in a color that is less near a bit boundary and is therefore
less likely to fail on specific hardware.

As an example of what was happening: the `touching color` block was
checking for `RGB(127,101,216)` with a mask of `RGB(0xF8,0xF8,0xF0)`. On
the CPU it would find `RGB(120,99,215)`, which is in range, but on some
GPUs the closest color it could find was `RGB(119,98,215)` which
mismatches on all four of the least significant bits -- one of which is
enabled in the mask.
 2020-05-12 15:52:51 -04:00
adroitwhiz
b9411bf51e Skip "doesn't touch say bubble" test 
There are some compatibility concerns to be worked out before the
corresponding bug can be fixed.
 2020-05-12 15:52:51 -04:00
adroitwhiz
3513cd77ae Adapt f9428ee to Playwright 2020-05-12 15:52:51 -04:00
adroitwhiz
d8c9f339f7
Merge pull request #576 from adroitwhiz/fix-ghost-touching-color 
Don't apply ghost effect to "color is touching color" drawable
 2020-05-11 16:29:17 -04:00
adroitwhiz
aaffc77b23 Clarify isTouchingColor ghost comment 2020-05-11 16:07:05 -04:00
adroitwhiz
d867e62c74 Don't apply ghost to "touching color" drawables 2020-05-11 16:07:05 -04:00
adroitwhiz
a7bec3a958
Merge pull request #604 from adroitwhiz/playwright 
Playwright: the re-wright
 2020-05-11 15:50:57 -04:00
adroitwhiz
0ce50b6cd6 log error.message 2020-05-11 15:38:11 -04:00
adroitwhiz
562e535a13 recache node_modules 2020-05-11 15:02:01 -04:00
adroitwhiz
42d3f6c012 uncache node_modules 2020-05-11 14:58:47 -04:00
adroitwhiz
9c01f364d4 Catch promise errors and exit with code 1 2020-05-11 14:43:54 -04:00
adroitwhiz
5d085f678f Add cached Playwright directory to Travis cache 2020-05-11 14:43:54 -04:00
adroitwhiz
7df536f492 Bump Node to 10 2020-05-11 14:43:54 -04:00
adroitwhiz
a41bcafac7 Use Playwright instead of Puppeteer 2020-05-11 14:43:54 -04:00
adroitwhiz
5566a600ba reference "wait for SVG skins to load" issue 2020-05-11 14:43:54 -04:00
adroitwhiz
34072d2f53 Fix file input in tests 2020-05-11 14:43:54 -04:00
adroitwhiz
fdd02a6bd6 download Chromium only when tests are run 2020-05-11 14:43:54 -04:00
adroitwhiz
ec141ff76d Replace Chromeless with Puppeteer 2020-05-11 14:43:54 -04:00
adroitwhiz
3f68e18b2e
Merge pull request #603 from LLK/revert-597-playwright 
Revert "Switch from Chromeless to Playwright for tests"
 2020-05-08 16:40:47 -04:00
adroitwhiz
813792359f
Revert "Switch from Chromeless to Playwright for tests" 2020-05-08 16:32:38 -04:00
adroitwhiz
7349c1967c
Merge pull request #597 from adroitwhiz/playwright 
Switch from Chromeless to Playwright for tests
 2020-05-08 15:47:48 -04:00
adroitwhiz
b873b6fec4 Bump Node to 10 2020-05-07 16:37:52 -04:00
adroitwhiz
51c867fa6d Use Playwright instead of Puppeteer 2020-05-07 16:21:37 -04:00
adroitwhiz
ddccd0fa79 reference "wait for SVG skins to load" issue 2020-05-07 16:08:28 -04:00
DD Liu
b35adaef88
Merge pull request #596 from LLK/greenkeeper/scratch-svg-renderer-0.2.0-prerelease.20200507183648 
Update scratch-svg-renderer to the latest version 🚀
 2020-05-07 15:45:34 -04:00
adroitwhiz
3612461f9c
Merge pull request #478 from adroitwhiz/fix-fence-bounds 
Always use getAABB for fence bounds
 2020-05-07 15:43:28 -04:00
adroitwhiz
7c710c0680
Merge pull request #474 from adroitwhiz/deobfuscate-convex-hull 
Ergonomics: Deobfuscate _getConvexHullPointsForDrawable
 2020-05-07 15:28:18 -04:00
adroitwhiz
fe91133565 Re-add link to 2.0's convex hull algorithm 2020-05-07 15:21:16 -04:00
greenkeeper[bot]
409df2a74d
fix(package): update scratch-svg-renderer to version 0.2.0-prerelease.20200507183648 2020-05-07 19:13:23 +00:00
Chris Willis-Ford
4b03eb29fd
Merge pull request #590 from adroitwhiz/i-hate-safari 
Tweak pen shader to avoid float precision issues
 2020-05-06 13:38:32 -07:00
adroitwhiz
51bceb68e5 Address review feedback 2020-05-06 16:21:18 -04:00
adroitwhiz
70c64f035c Deobfuscate _getConvexHullPointsForDrawable 2020-05-05 16:25:38 -04:00
adroitwhiz
4b7558f2d2 Fix another annoying precision bug. 
Who knew fragment shaders were so difficult?
 2020-05-01 14:04:03 -04:00
DD Liu
84f878e553
Merge pull request #591 from LLK/master 
Merge master into develop
 2020-04-27 13:47:31 -04:00
DD Liu
b6424a2f80
Merge pull request #588 from adroitwhiz/fix-resize 
Call draw() after resizing canvas
 2020-04-27 13:38:25 -04:00
adroitwhiz
0b47d87f2f Tweak pen shader to avoid float precision issues 2020-04-25 19:43:20 -04:00
adroitwhiz
41e21ed129 Only resize canvas when necessary 2020-04-24 18:51:48 -04:00
adroitwhiz
6d28f42d57 Call draw() after resizing canvas 2020-04-24 16:20:11 -04:00
DD Liu
4b2e17186b
Merge pull request #585 from adroitwhiz/update-silhouette-convex-hull 
Update drawables' matrix + silhouette in _getConvexHullPointsForDrawable
 2020-04-24 14:59:17 -04:00
DD Liu
6dd833a7f9
Merge pull request #586 from LLK/revert-582-revert-580-revert-559-revert-438-pen-shader 
Revert "Revert "Revert "Revert "Draw pen lines via fragment shader""""
 2020-04-22 19:45:49 -04:00
DD Liu
5bf185262a
Revert "Revert "Revert "Revert "Draw pen lines via fragment shader"""" 2020-04-22 18:16:58 -04:00
adroitwhiz
e9d6c1d13f Update drawables' matrix+silhouette for hull calc. 2020-04-15 04:51:34 -04:00
DD Liu
58bd9cbe19
Merge pull request #582 from LLK/revert-580-revert-559-revert-438-pen-shader 
Revert "Revert "Revert "Draw pen lines via fragment shader"""
 2020-04-09 12:30:38 -04:00
DD Liu
bf43ef363a
Revert "Revert "Revert "Draw pen lines via fragment shader""" 2020-04-09 12:27:19 -04:00
DD Liu
a94f238ea1
Merge pull request #580 from LLK/revert-559-revert-438-pen-shader 
Revert "Revert "Draw pen lines via fragment shader""
 2020-04-02 15:14:15 -04:00
DD Liu
4a521509da
Merge branch 'develop' into revert-559-revert-438-pen-shader 2020-04-02 14:28:08 -04:00
DD Liu
d17066b745
Merge pull request #475 from adroitwhiz/penskin-silhouette-from-data 
Set PenSkin silhouette data directly
 2020-04-02 14:24:49 -04:00
DD Liu
6cde82d33d
Merge pull request #556 from adroitwhiz/unmultiply-extracted-drawables 
Un-premultiply extracted drawables
 2020-04-02 14:24:34 -04:00