From 2479080a77da0d5dee41df94024d9545e52c93fa Mon Sep 17 00:00:00 2001
From: AlexPresso <blond.alexandre@hotmail.com>
Date: Fri, 3 Jun 2022 15:31:30 +0200
Subject: [PATCH] Cleaning

---
 .github/ISSUE_TEMPLATE/bug_report.md | 21 ++++++++++++++++++---
 README.md                            | 10 +++++-----
 patcher.sh                           |  4 ++--
 3 files changed, 25 insertions(+), 10 deletions(-)

diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
index 53ff018..69d591c 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.md
+++ b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -35,11 +35,26 @@ A clear and concise description of what the bug is.
 - Copy paste those lines in a new [gist](https://gist.github.com/)
 - Add the gist link to the issue
 
-## `ffmpeg-FFMxxxx.stderr` (containing chunks transcoding operations)
+## `ffmpeg-xxxx.stderr` (containing chunks transcoding operations)
 - When you ran `ls -al | grep ffmpeg` you should have seen another file that looks like `ffmpeg-FFMxxxx.stderr`
-- Type `tail -100 ffmpeg-FFMxxxx.stderr` (replacing the filename by the correct one)
+- Type `tail -100 ffmpeg-xxxx.stderr` (replacing the filename by the correct one)
 - Copy paste those lines in a new [gist](https://gist.github.com/)
-- Type `head -300 ffmpeg-FFMxxxx.stderr` (replacing the filename by the correct one)
+- Type `head -300 ffmpeg-xxxx.stderr` (replacing the filename by the correct one)
+- Copy paste those lines in another new [gist](https://gist.github.com/)
+- Copy paste all the gists links in the issue
+
+## `gstreamer.log` (containing the ffmpeg-wrapper execution logs)
+- Go to the temporary directory: `cd /tmp`
+- Type `ls -al | grep gst` to list all files containing "ffmpeg" and check you have one named `ffmpeg.log`
+- Type `tail -200 gstreamer.log` to print the last 200 lines to the console
+- Copy paste those lines in a new [gist](https://gist.github.com/)
+- Add the gist link to the issue
+
+## `gstlaunch-xxxx.stderr` (containing chunks transcoding operations)
+- When you ran `ls -al | grep gst` you should have seen another file that looks like `ffmpeg-FFMxxxx.stderr`
+- Type `tail -100 gstlaunch-xxxx.stderr` (replacing the filename by the correct one)
+- Copy paste those lines in a new [gist](https://gist.github.com/)
+- Type `head -300 gstlaunch-xxxx.stderr` (replacing the filename by the correct one)
 - Copy paste those lines in another new [gist](https://gist.github.com/)
 - Copy paste all the gists links in the issue
 
diff --git a/README.md b/README.md
index 5de95e9..83c9b16 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@
   <img src="https://github.com/AlexPresso/VideoStation-FFMPEG-Patcher/blob/main/banner.png?raw=true" height=200px alt="Banner">
 </p>
 
-This patcher is designed to simplify the installation steps from this [Gist](https://gist.github.com/BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e) (huge thanks to [Benjamin Poncet](https://github.com/BenjaminPoncet)) and enable **DTS**, **EAC3** and **TrueHD** support to Synology VideoStation by replacing the ffmpeg library files by a wrapper using SynoCommunity ffmpeg.
+This patcher is designed to simplify the installation steps from this [Gist](https://gist.github.com/BenjaminPoncet/bbef9edc1d0800528813e75c1669e57e) (huge thanks to [Benjamin Poncet](https://github.com/BenjaminPoncet)) and enable **DTS**, **EAC3** and **TrueHD** support to Synology VideoStation by replacing the original ffmpeg and gstreamer files by a wrapper using SynoCommunity packages.
 
 ## Dependencies
 - DSM 6.2.2-24922 Update 4 (and above)
@@ -30,7 +30,7 @@ Basic command:
 With options:  
 `curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- <flags>`
 
-| Flags | Required | Description                                                                     |
-|-------|----------|---------------------------------------------------------------------------------|
-| -a    | No       | Action flag: choose between patch or unpatch ; example: `-a patch`              |
-| -b    | No       | Branch flag: allows you to choose the wrapper branch to use ; example `-b main` |                                                        
+| Flags | Required | Description                                                                     | Default |
+|-------|----------|---------------------------------------------------------------------------------|---------|
+| -a    | No       | Action flag: choose between patch or unpatch ; example: `-a patch`              | patch   |
+| -b    | No       | Branch flag: allows you to choose the wrapper branch to use ; example `-b main` | main    |                                                  
diff --git a/patcher.sh b/patcher.sh
index 006d563..2fdcf7a 100755
--- a/patcher.sh
+++ b/patcher.sh
@@ -48,7 +48,7 @@ function welcome_motd() {
 
 function restart_packages() {
   if [[ -d $cp_bin_path ]]; then
-    log "INFO" "Restarting CodecPack..."
+    info "Restarting CodecPack..."
     synopkg restart CodecPack
   fi
 
@@ -81,7 +81,7 @@ function patch() {
       wget -q -O - "$repo_base_url/blob/$branch/$filename-wrapper.sh?raw=true" > "$vs_path/bin/$filename"
       chown root:VideoStation "$vs_path/bin/$filename"
       chmod 750 "$vs_path/bin/$filename"
-      chmod u+s "$vs_path/bin/ffmpeg"
+      chmod u+s "$vs_path/bin/$filename"
     fi
   done