mirror of
https://github.com/ohmyzsh/ohmyzsh.git
synced 2025-11-05 05:51:17 +08:00
There is no inherent security vulnerability in the workflow, but there were certain practices that increased latent risk. In this commit, we: - Explicitly bind app token for each step that needs it, instead of setting it for all steps after "Store app token" - Refactor "classify" step, to not rely on files passed around, and instead uses only awk script. - Remove all instances of template injection within `run` scripts. There was nothing dangerous, but the practice is unsafe. - Sanitize all unwanted characters from PR plugin and theme names. References: W2M1-06 W2M1-07
156 lines
5.3 KiB
YAML
156 lines
5.3 KiB
YAML
name: Project tracking
|
|
on:
|
|
issues:
|
|
types: [opened, reopened]
|
|
pull_request_target:
|
|
types: [opened, reopened, synchronize]
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
permissions: {}
|
|
jobs:
|
|
add-to-project:
|
|
name: Add to project
|
|
runs-on: ubuntu-latest
|
|
if: github.repository == 'ohmyzsh/ohmyzsh'
|
|
steps:
|
|
- name: Harden the runner (Audit all outbound calls)
|
|
uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1
|
|
with:
|
|
egress-policy: audit
|
|
- name: Authenticate as @ohmyzsh
|
|
id: generate-token
|
|
uses: actions/create-github-app-token@67018539274d69449ef7c02e8e71183d1719ab42 # v2.1.4
|
|
with:
|
|
app-id: ${{ secrets.OHMYZSH_APP_ID }}
|
|
private-key: ${{ secrets.OHMYZSH_APP_PRIVATE_KEY }}
|
|
- name: Read project data
|
|
env:
|
|
GH_TOKEN: ${{ steps.generate-token.outputs.token }}
|
|
ORGANIZATION: ohmyzsh
|
|
PROJECT_NUMBER: "1"
|
|
run: |
|
|
# Get Project data
|
|
gh api graphql -f query='
|
|
query($org: String!, $number: Int!) {
|
|
organization(login: $org){
|
|
projectV2(number: $number) {
|
|
id
|
|
fields(first:20) {
|
|
nodes {
|
|
... on ProjectV2Field {
|
|
id
|
|
name
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}' -f org=$ORGANIZATION -F number=$PROJECT_NUMBER > project_data.json
|
|
|
|
# Parse project data
|
|
cat >> "$GITHUB_ENV" <<EOF
|
|
PROJECT_ID=$(jq '.data.organization.projectV2.id' project_data.json)
|
|
PLUGIN_FIELD_ID=$(jq '.data.organization.projectV2.fields.nodes[] | select(.name == "Plugin") | .id' project_data.json)
|
|
THEME_FIELD_ID=$(jq '.data.organization.projectV2.fields.nodes[] | select(.name == "Theme") | .id' project_data.json)
|
|
EOF
|
|
- name: Add to project
|
|
env:
|
|
GH_TOKEN: ${{ steps.generate-token.outputs.token }}
|
|
ISSUE_OR_PR_ID: ${{ github.event.issue.node_id || github.event.pull_request.node_id }}
|
|
run: |
|
|
item_id="$(gh api graphql -f query='
|
|
mutation($project: ID!, $content: ID!) {
|
|
addProjectV2ItemById(input: {projectId: $project, contentId: $content}) {
|
|
item {
|
|
id
|
|
}
|
|
}
|
|
}
|
|
' -f project="$PROJECT_ID" -f content="$ISSUE_OR_PR_ID" --jq '.data.addProjectV2ItemById.item.id')"
|
|
|
|
echo "ITEM_ID=$item_id" >> $GITHUB_ENV
|
|
- name: Classify Pull Request
|
|
if: github.event_name == 'pull_request_target'
|
|
env:
|
|
GH_TOKEN: ${{ steps.generate-token.outputs.token }}
|
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
|
run: |
|
|
# Get the list of modified files in the PR, and extract plugins and themes
|
|
gh pr view "$PR_NUMBER" \
|
|
--repo "$GITHUB_REPOSITORY" \
|
|
--json files --jq '.files.[].path' | awk -F/ '
|
|
BEGIN {
|
|
plugins = 0
|
|
themes = 0
|
|
}
|
|
/^plugins\// {
|
|
if (plugin == $2) next
|
|
plugin = $2
|
|
plugins++
|
|
}
|
|
/^themes\// {
|
|
gsub(/\.zsh-theme$/, "", $2)
|
|
if (theme == $2) next
|
|
theme = $2
|
|
themes++
|
|
}
|
|
END {
|
|
# plugin and theme are values controlled by the PR author
|
|
# so we should sanitize them before using anywhere else
|
|
if (plugins == 1) {
|
|
gsub(/[^a-zA-Z0-9._-]/, "", plugin)
|
|
print "PLUGIN=" plugin
|
|
}
|
|
if (themes == 1) {
|
|
gsub(/[^a-zA-Z0-9._-]/, "", theme)
|
|
print "THEME=" theme
|
|
}
|
|
}
|
|
' >> "$GITHUB_ENV"
|
|
- name: Fill Pull Request fields in project
|
|
if: github.event_name == 'pull_request_target'
|
|
env:
|
|
GH_TOKEN: ${{ steps.generate-token.outputs.token }}
|
|
run: |
|
|
gh api graphql -f query='
|
|
mutation (
|
|
$project: ID!
|
|
$item: ID!
|
|
$plugin_field: ID!
|
|
$plugin_value: String!
|
|
$theme_field: ID!
|
|
$theme_value: String!
|
|
) {
|
|
set_plugin: updateProjectV2ItemFieldValue(input: {
|
|
projectId: $project
|
|
itemId: $item
|
|
fieldId: $plugin_field
|
|
value: {
|
|
text: $plugin_value
|
|
}
|
|
}) {
|
|
projectV2Item {
|
|
id
|
|
}
|
|
}
|
|
set_theme: updateProjectV2ItemFieldValue(input: {
|
|
projectId: $project
|
|
itemId: $item
|
|
fieldId: $theme_field
|
|
value: {
|
|
text: $theme_value
|
|
}
|
|
}) {
|
|
projectV2Item {
|
|
id
|
|
}
|
|
}
|
|
}
|
|
' -f project="$PROJECT_ID" -f item="$ITEM_ID" \
|
|
-f plugin_field="$PLUGIN_FIELD_ID" -f plugin_value="$PLUGIN" \
|
|
-f theme_field="$THEME_FIELD_ID" -f theme_value="$THEME" \
|
|
--silent
|