github/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2026-10-24 23:33:43 +08:00
Code Issues Projects Releases Wiki Activity

[Perf] Optimize nvm_tree_contains_path with in-memory POSIX parent-walk

Browse Source 
Replace looping subshell process forks (dirname)
in nvm_tree_contains_path with case-guarded in-memory POSIX parameter expansion () and exact string equality comparisons.

Ensures literal string matching for glob metacharacters (*, ?, [])
and full zsh compatibility across all platforms.
This commit is contained in:
Thanniru Sai Teja
2026-09-03 12:24:16 +05:30
committed by Jordan Harband
parent e361b93e4b
commit cd84623ab2
2 changed files with 39 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/fast/Unit tests/nvm_tree_contains_path
View File

@@ -29,4 +29,11 @@ nvm_tree_contains_path tmp2 tmp2/node || die '"tmp2" should contain "tmp2/node"'
nvm_tree_contains_path tmp2 tmp/node && die '"tmp2" should not contain "tmp/node"'
nvm_tree_contains_path tmp/ tmp/node || die '"tmp/" should contain "tmp/node"'
nvm_tree_contains_path tmp// tmp/node || die '"tmp//" should contain "tmp/node"'
nvm_tree_contains_path / /tmp/node || die '"/" should contain "/tmp/node"'
nvm_tree_contains_path "tmp[glob]" "tmp[glob]/node" || die '"tmp[glob]" should contain "tmp[glob]/node"'
nvm_tree_contains_path "tmp" "tmp[glob]/node" && die '"tmp" should not contain "tmp[glob]/node"'
cleanup